Bypass the sandbox when running build:patterns #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses `wp_remote_get()` and the `CURLOPT_CONNECT_TO` curl option to ensure `yarn build:patterns` will always connect to production servers, even if `wordpress.org` is sandboxed on your local machine. Without this, Docker will fail to connect when you're sandboxed, because it respects /etc/hosts but doesn't use the proxy, so the request is denied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
wp_remote_get()and theCURLOPT_CONNECT_TOcurl option to ensureyarn build:patternswill always connect to production servers, even ifwordpress.orgis sandboxed on your local machine.Without this, Docker will fail to connect when you're sandboxed, because it respects /etc/hosts but doesn't use the proxy, so the request is denied.
See #118 (comment)
How to test the changes in this Pull Request:
/etc/hosts.yarn build:patternsshould work fine with this PR applied.cURL error 28: Failed to connecttimeout.