Hmm.. you did, but TOTP isn't using a consistent filter.

There's two fields, label which should be "$issuer: $accountName", and issuer which should be "$issuer".

That filter only changes the label, it doesn't change the issuer, and as a result the TOTP QR no longer follows this google-authenticator line:

https://github.com/google/google-authenticator/wiki/Key-Uri-Format#issuer (emphasis mine)

STRONGLY RECOMMENDED: The issuer parameter is a string value indicating the provider or service this account is associated with, URL-encoded according to RFC 3986. If the issuer parameter is absent, issuer information may be taken from the issuer prefix of the label. If both issuer parameter and issuer label prefix are present, they should be equal.

The QR generated is something like this:

otpauth://totp/WordPress.org:dd32?secret=KEYKEYKEY&issuer=WordPress.org Forums

Basically, the two_factor_totp_title filter should only be used to change the component after the colon.

A new filter of two_factor_totp_issuer which controls the input into the second filter would probably be the most correct otpion here.

TOTP title is "WordPress.org Forums" #69

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions