Skip to content

[Xdebug Bridge] Correct error related to unresolved promises in bridge #2422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 25, 2025
Merged

[Xdebug Bridge] Correct error related to unresolved promises in bridge #2422

merged 5 commits into from
Jul 25, 2025

Conversation

mho22
Copy link
Collaborator

@mho22 mho22 commented Jul 25, 2025 •
edited by adamziel
Loading

Motivation for the change, related issues

Resolves the problem introduced in #2411:

The promise returned by getPHPFile() is never resolved and the PHP source code never loads in devtools

@mho22
Copy link
Collaborator Author

mho22 commented Jul 25, 2025 •
edited
Loading

I was thinking of your code with type string | Promise<string> in your current wip. And it should probably be the best solution instead of using Promises where there is no means of it. I added them previoulsy to go forward in my exploration.

Are you ok with setting string | Promise<string> instead ?

@mho22 mho22 marked this pull request as draft July 25, 2025 00:40
@mho22 mho22 marked this pull request as ready for review July 25, 2025 08:14
@mho22 mho22 marked this pull request as draft July 25, 2025 08:15
@mho22 mho22 marked this pull request as ready for review July 25, 2025 08:27
@adamziel adamziel added [Type] Bug An existing feature does not function as intended XDebug labels Jul 25, 2025
@adamziel adamziel merged commit 6e72a6e into trunk Jul 25, 2025
24 of 25 checks passed
@adamziel adamziel deleted the correct-oversight-in-start-bridge branch July 25, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Type] Bug An existing feature does not function as intended XDebug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mho22 @adamziel