Skip to content

Add lazily evaluated translation calls #4444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from

Conversation

swissspidy
Copy link
Member

@swissspidy swissspidy commented May 11, 2023

Tries to apply the latest patch from 2019 to current code base.

  • Needs performance tests
  • Removed separate class for translations with context
  • Also uses proxy objects for plural translations
  • Currently missing assertion method overrides (e.g. assertSame and assertEquals) to automatically resolve string proxies in tests as seen in the latest patch

Trac ticket: https://core.trac.wordpress.org/ticket/41305


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@spacedmonkey
Copy link
Member

I am seeing this be around 2% slower. :(

Screenshot 2023-05-12 at 13 12 15 Screenshot 2023-05-12 at 13 13 51

@swissspidy swissspidy force-pushed the 41305-lazy-translations branch from 4d875ba to 18a19bf Compare August 24, 2023 21:00
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@swissspidy swissspidy closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants