theme.json: add title key to i18n schema
#2483
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 31, 2022
theme.json: add title key to translatetheme.json: add title key to i18n schema
|
Committed with 39a5bac. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket https://core.trac.wordpress.org/ticket/55495
This PR ports the related Gutenberg PR at WordPress/gutenberg#39936
What?
This PR adds
titleas a new key to translate from atheme.jsonfile. It's necessary to fix the wp-cli i18n-command tests at wp-cli/i18n-command#306Why?
The
titlekey from a style variation is shown to the user, hence, it needs to be translatable.How?
By adding the key to the i18n schema we allow the i18n-command from the wp-cli to pick it up. See wp-cli/i18n-command#306 Though the wp-cli uses the schema from WordPress
trunkso we also need to port the changes there.Testing Instructions
This PR only prepares the code for the wp-cli to pick up translations, so there's nothing to test other than verifying that it doesn't break anything. This is what I did: