Skip to content

Fix/assets #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 3, 2025
Merged

Fix/assets #683

merged 4 commits into from
Jul 3, 2025

Conversation

jeffpaul
Copy link
Member

What?

Related to #544:

Is assets folder within SVN trunk necessary given that duplicates the root assets folder?

This PR renames the assets folder to .wordpress-org and ignores it for distribution/deploy.

Why?

This should remove the duplicate assets folder from our trunk branch on SVN (https://plugins.trac.wordpress.org/browser/two-factor/#trunk/assets) and leave the top level assets folder with these files (https://plugins.trac.wordpress.org/browser/two-factor/assets).

How?

Testing Instructions

Screenshots or screencast

Changelog Entry

Added - New feature.
Changed - Existing functionality.
Deprecated - Soon-to-be removed feature.
Removed - Feature.
Fixed - Bug fix.
Security - Vulnerability.

@jeffpaul jeffpaul requested a review from kasparsd April 30, 2025 21:15
Copy link
Collaborator

@kasparsd kasparsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had question about the directory being added .gitignore. I believe we want to keep tracking it in the repo, just not push it to SVN (covered by .distignore update).

@@ -1,4 +1,5 @@
# Directories
/.wordpress-org/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like action-wordpress-plugin-deploy defaults to .wordpress-org being the default name for the assets directory so there is no additional config need for the GitHub Action.

@jeffpaul jeffpaul requested a review from kasparsd July 2, 2025 20:03
@kasparsd kasparsd merged commit 05a01dc into master Jul 3, 2025
54 checks passed
@kasparsd kasparsd deleted the fix/assets branch July 3, 2025 06:27
@kasparsd kasparsd mentioned this pull request Jul 3, 2025
@jeffpaul jeffpaul added this to the 0.14.0 milestone Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants