Label recommended methods to simplify the configuration #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparsd
commented
Apr 21, 2025
| <?php echo esc_html( sprintf( __( 'Enable %s', 'two-factor' ), $object->get_label() ) ); ?> | ||
| <strong><?php echo esc_html( sprintf( __( 'Enable %s', 'two-factor' ), $object->get_label() ) ); ?></strong> | ||
| <?php if ( in_array( $provider_key, $recommended_provider_keys, true ) ) : ?> | ||
| <abbr title="<?php esc_attr_e( 'This method is more secure and easy to use', 'two-factor' ); ?>" class="two-factor-method-recommended"><?php esc_html_e( 'Recommended', 'two-factor' ); ?></abbr> |
There was a problem hiding this comment.
Adding these flags as <attr> elements that provide additional context inline on hover and for screen readers.
| <p> | ||
| <?php esc_html_e( 'Please scan the QR code or manually enter the key, then enter an authentication code from your app in order to complete setup.', 'two-factor' ); ?> | ||
| <?php esc_html_e( 'Please scan the QR code or manually copy the shared secret key from below to your Authenticator app:', 'two-factor' ); ?> |
There was a problem hiding this comment.
This message is now split into two -- one here above about the secret code and another closer to the code input box for clarity.
|
That looks good to me 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Marks methods that are relatively secure and easy to setup as "Recommended".
Why?
Fixes #483.
How?
two_factor_recommended_providersfilter that allows adding/removing methods from being "Recommended".Testing Instructions
Screenshots or screencast
Changelog Entry
Added: mark TOTP and backup codes as recommended methods to simplify the decision making.