Fix PHP 8.4 Implicitly marking parameter $previous as nullable is deprecated #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix PHP 8.4 warning
|
The plugin is currently supporting PHP 7.2 and above: It appears that support for nullable arguments was added to 7.1 so this is safe to merge. Thanks for the pull request! Noting that U2F support will be removed soon #439 but having this fixed is definitely worth it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PHP 8.4 requires
nullvalues to be explicitly declared: https://www.php.net/manual/en/migration84.deprecated.phpThis PR does that for the U2F.php class fixing the warning:
Why?
To avoid noise in the PHP logs and it is likely this may be a fatal in a future version of PHP.
How?
This adds a
?to the class to allow it to be explicitly null.Testing Instructions
Install PHP 8.4, make the change in the PR and watch the error go away.
Changelog Entry
Fixed - PHP 8.4: Implicitly marking parameter $previous as nullable is deprecated (#663)