SAS dataset label #213
Merged
SAS dataset label #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanmiller
reviewed
Sep 8, 2020
| &ctx->text_blobs[0][off], | ||
| ctx->col_info[0].name_ref.offset - off | ||
| ); | ||
| } |
There was a problem hiding this comment.
I think additional pointer validation is necessary here. We need to ensure:
- The first
memcmpdoes not overruntext_blob_lengths[0] offis not larger thanctx->col_info[0].name_ref.offsetctx->file_labelis not overrun during thememcpy
Additionally: file_label likely needs to be recoded. So I suggest using readstat_convert here instead of the memcpy. That will automatically solve the third issue. Something like
readstat_convert(ctx->file_label, sizeof(ctx->file_label),
&ctx->text_blobs[0][off], ctx->col_info[0].name_ref.offset - off, ctx->converter)Then check the return value.
There was a problem hiding this comment.
Should be addressed with the last commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the name of a SAS dataset also its label is read in from sas7bdat and printed the dataset's metadata is listed.