Skip to content

Fix issue with speed example - does not compile on master branch #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 8, 2024
Merged

Fix issue with speed example - does not compile on master branch #277

merged 3 commits into from
Sep 8, 2024

Conversation

jwlodek
Copy link
Contributor

@jwlodek jwlodek commented Sep 2, 2024 •
edited
Loading

The signature of wiringPiSetupGpioDevice changed in f3415b5, but this example's code was not changed to reflect this which causes it to fail to compile on the master branch. Looking through the source code of that commit, I believe this change should restore the pre-change behavior for this example.

jwlodek@raspberrypi:/epics/utils/WiringPi/examples $ make speed
[CC] speed.c
speed.c: In function ‘main’:
speed.c:96:3: error: too few arguments to function ‘wiringPiSetupGpioDevice’
   wiringPiSetupGpioDevice () ;
   ^~~~~~~~~~~~~~~~~~~~~~~
In file included from speed.c:26:
/usr/local/include/wiringPi.h:228:13: note: declared here
 extern int  wiringPiSetupGpioDevice(enum WPIPinType pinType); //Interface V3.3
             ^~~~~~~~~~~~~~~~~~~~~~~
make: *** [Makefile:158: speed.o] Error 1

I suggest creating a CI workflow for testing example compilation in addition to the project build test.

@mstroh76 mstroh76 changed the base branch from master to gpiochip September 8, 2024 16:58
@mstroh76 mstroh76 self-requested a review September 8, 2024 16:58
@mstroh76 mstroh76 merged commit f0c8991 into WiringPi:gpiochip Sep 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstroh76 mstroh76 Awaiting requested review from mstroh76

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwlodek @mstroh76