Implement ISR for all Raspberry Pi Boards - new driver interface #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwallner
reviewed
Mar 22, 2024
There was a problem hiding this comment.
I guess this file got here by accident?
mwallner
reviewed
Mar 22, 2024
There was a problem hiding this comment.
for the next time, it'd be great if we could have a separate commit for bumping the version (just before the actual release) - this way people who may build from source / a non-master branch wouldn't get the "new version" in advance. (it may actually not be the final version - therefore we should only bump the version at the very last moment possible)
mwallner
approved these changes
Mar 22, 2024
|
Yes
Manfred Wallner ***@***.***> schrieb am Fr. 22. März 2024 um
20:19:
… ***@***.**** approved this pull request.
generally speaking these changes look good, does this mean we'll have ISR
working *again* on Raspberry Pi <= 4 with the latest kernel versions AS
WELL AS support for Pi5? 🤯
—
Reply to this email directly, view it on GitHub
<#205 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACNIP62MQFWQBYJVNWXX2ITYZR74BAVCNFSM6AAAAABFD2NU32VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNJVGYYTMNJRGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
New ISR works with all Pi's and old and new kernel as well. There is even the possibility to stop isr , that was hardly missing before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, wiringPi utilizes the same GPIO ABI as libgpiod.
fixes #204
implements #200
implements #208