Skip to content

No home directory on vxWorks #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2019
Merged

No home directory on vxWorks #24

merged 1 commit into from
Sep 20, 2019

Conversation

BaoshanPang
Copy link

n-salim
n-salim approved these changes Sep 20, 2019
View reviewed changes
Copy link

@n-salim n-salim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing my untested code (sorry!). This is definitely the right fix, the previous home_dir ended up calling functions that were implemented as no-ops. The function that calls this "std::env::home_dir" is marked as "deprecated" and is not used elsewhere in libstd (including tests).

@n-salim n-salim mentioned this pull request Sep 20, 2019
Merged
@n-salim n-salim merged commit fbf9fa4 into master Sep 20, 2019
@BaoshanPang BaoshanPang deleted the home_directory branch November 11, 2019 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@n-salim n-salim n-salim approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BaoshanPang @n-salim @bpangWR