Update visjs and Fix #128 and #129 #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szobov
reviewed
Apr 14, 2022
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/vis/4.16.1/vis.css" type="text/css" /> | ||
| <script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/vis/4.16.1/vis-network.min.js"> </script> | ||
| <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/vis-network@latest/styles/vis-network.css" type="text/css" /> | ||
| <script type="text/javascript" src="https://cdn.jsdelivr.net/npm/vis-network@latest/dist/vis-network.min.js"> </script> |
There was a problem hiding this comment.
I'm not sure it's a good idea to put the latest version, because it introduces a chance, that backward compatibility will be broken at some moment.
But if we can set up a CI with 2 different jobs: one to build with some fixed version, one to build with the latest one, it would be much more useful IMO.
There was a problem hiding this comment.
I can see that, but on the other hand half of the issues in this Repo are from issues with the old version and from People that don't understand what this repos does and that graph rendering is done from vis-network.
ceandrade
pushed a commit
to ceandrade/pyvis
that referenced
this pull request
Jul 10, 2025
…ptions Update visjs and Fix WestHealth#128 and WestHealth#129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #128 and #129.
I also removed some junk from
/home/unpingco/.wingpro8/remote-8.1.2.1, fixed the notebook to use the local version directly and added an example on how to useset_optionsandfrom_DOT.