Skip to content

Fix hidden links in MissingFunctionAC.html. #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2023
Merged

Fix hidden links in MissingFunctionAC.html. #1710

merged 1 commit into from
Dec 29, 2023

Conversation

peter17
Copy link
Contributor

@peter17 peter17 commented Dec 23, 2023

This fixes 2 issues:

  1. there are 3 links but the exercise expects 2 answers so it is confusing for users
  2. the links href start with "/" so they are broken if Webgoat is deployed to a subfolder (e.g. mysite.com/webgoat)

Thanks!

zubcevic
zubcevic approved these changes Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@zubcevic zubcevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this correction

@zubcevic zubcevic merged commit 4ebb869 into WebGoat:main Dec 29, 2023
nbaars pushed a commit that referenced this pull request Mar 19, 2024
@peter17 @nbaars
Fix hidden links in MissingFunctionAC.html. (#1710)
0afeab7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zubcevic zubcevic zubcevic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peter17 @zubcevic