Skip to content

wast-parser.cc: Fix a crash from failing (module quote ...) #2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2024
Merged

wast-parser.cc: Fix a crash from failing (module quote ...) #2509

merged 2 commits into from
Nov 12, 2024

Conversation

keithw
Copy link
Member

@keithw keithw commented Nov 11, 2024

ParseWatModule leaves the module as a nullptr on failure. The attached test could cause a segfault in wast2json before this PR.

@keithw keithw requested a review from sbc100 November 11, 2024 10:03
sbc100
sbc100 reviewed Nov 11, 2024
View reviewed changes
@keithw keithw force-pushed the check-parsewat-return branch from 2dd7e16 to c491a8f Compare November 11, 2024 23:14
@keithw keithw force-pushed the check-parsewat-return branch from c491a8f to 4664307 Compare November 12, 2024 05:01
@keithw keithw enabled auto-merge (squash) November 12, 2024 05:01
@keithw keithw merged commit 958d0a7 into main Nov 12, 2024
18 checks passed
@keithw keithw deleted the check-parsewat-return branch November 12, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keithw @sbc100