-
Notifications
You must be signed in to change notification settings - Fork 764
Harden against invalid alignment #2411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
41931ae
to
a517995
Compare
cc @keithw because oss-fuzz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this!
a517995
to
1a566e6
Compare
72582c2
to
0386a27
Compare
Thanks, and thanks for the ping. Do you think it would be better to consolidate the three |
E.g. keithw/wabt@b09d4e0 |
we figured having the check in the same function is what caused the issue in the first place. further, different contexts may give different meanings to the alignment flags, so we would be against calling it "has memidx" in that case. would you have another way to enforce that CheckAlignment is called? |
how about this? |
Let's just go back to the way you had it and call it done. |
oh ;-; okay |
46434e5
to
0386a27
Compare
Chasing https://crbug.com/oss-fuzz/51561
Let's see if this breaks anything...
The issue only triggers if both conditions are true: