Skip to content

Update testsuite #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2023
Merged

Update testsuite #2287

merged 1 commit into from
Oct 24, 2023

Conversation

keithw
Copy link
Member

@keithw keithw commented Aug 26, 2023 •
edited
Loading

Sequenced behind #2272.

This updates the testsuite. The major changes:

(The only missing test is relaxed-simd/relaxed_dot_product.txt, which it looks like we believe is going away per #2115.)

@keithw keithw requested a review from sbc100 August 26, 2023 07:25
@keithw keithw marked this pull request as draft August 27, 2023 19:12
@keithw
Copy link
Member Author

keithw commented Aug 27, 2023

Reverting to draft as I think there may be a cleaner way to do the global.get change, and in any event I'll try to split this one up.

@keithw keithw mentioned this pull request Aug 30, 2023
Merged
@keithw keithw removed the request for review from sbc100 August 31, 2023 18:35
@keithw keithw force-pushed the w2c-tail-call branch 3 times, most recently from e518334 to 25095c0 Compare September 11, 2023 20:10
@keithw keithw mentioned this pull request Sep 11, 2023
Merged
@keithw keithw marked this pull request as ready for review September 11, 2023 22:55
@keithw keithw force-pushed the w2c-tail-call branch 7 times, most recently from 5084240 to 7ca62d2 Compare September 20, 2023 17:53
Base automatically changed from w2c-tail-call to main October 24, 2023 17:28
@keithw keithw requested a review from sbc100 October 24, 2023 17:30
sbc100
sbc100 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp lgtm

@keithw
Update testsuite
fdc7daf 
Some of the exception-handling tests now depend on tail-calls.

The only missing test is relaxed-simd/relaxed_dot_product.txt, which
we believe is going away per #2115.
@keithw keithw enabled auto-merge (squash) October 24, 2023 21:16
@keithw keithw merged commit 41a0378 into main Oct 24, 2023
@keithw keithw deleted the update-testsuite branch October 24, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keithw @sbc100