Skip to content

Remove newline characters from output #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 24, 2022
Merged

Remove newline characters from output #40

merged 4 commits into from
Oct 24, 2022

Conversation

andrewkatz
Copy link
Contributor

Looks like they are breaking the next-semver action:

Fatal error: Uncaught Version\Exception\InvalidVersionString: Version string 'v1.0.0
' is not valid and cannot be parsed in /workdir/vendor/nikolaposa/version/src/Exception/InvalidVersionString.php:16
Stack trace:
#0 /workdir/vendor/nikolaposa/version/src/Version.php(65): Version\Exception\InvalidVersionString::notParsable('v1.0.0\r')
#1 /workdir/src/Next.php(25): Version\Version::fromString('v1.0.0\r')
#2 /workdir/next.php(14): WyriHaximus\Github\Actions\NextSemVers\Next::run('v1.0.0\r', true)
#3 /workdir/next.php(17): {closure}()
#4 {main}
  thrown in /workdir/vendor/nikolaposa/version/src/Exception/InvalidVersionString.php on line 16

@andrewkatz andrewkatz mentioned this pull request Oct 24, 2022
Closed
WyriHaximus
WyriHaximus reviewed Oct 24, 2022
View reviewed changes
@WyriHaximus WyriHaximus added this to the v1.2.1 milestone Oct 24, 2022
WyriHaximus
WyriHaximus approved these changes Oct 24, 2022
View reviewed changes
Copy link
Owner

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix 👍

@WyriHaximus WyriHaximus merged commit ad051e0 into WyriHaximus:master Oct 24, 2022
@andrewkatz
Copy link
Contributor Author

Happy to help, thanks for responding quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees
No one assigned
Labels
JavaScript 🦏
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewkatz @WyriHaximus