Skip to content

Conversation

Wuyunfan-BUPT
Copy link
Owner

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

Wuyunfan-BUPT and others added 7 commits September 4, 2024 21:55
* 修复环境变量设置标签失效bug

* pmd
 fix
Co-authored-by: xushengbin <xushengbin@tidecloud.org>
…m. (#12619)

* [ISSUE #12103] Enhance ClientWorker support grpc request timeout param.

* test case.
* fix derby usage filed

* code style

* code style

* code style

* code style
@Wuyunfan-BUPT Wuyunfan-BUPT merged commit 7e29190 into Wuyunfan-BUPT:fix_upload_artifacts_version Sep 18, 2024
@CLAassistant
Copy link

CLAassistant commented Sep 18, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 5 committers have signed the CLA.

✅ Wuyunfan-BUPT
❌ shiyiyue1102
❌ shengbinxu
❌ XiaZhouxx
❌ KomachiSion
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants