This repository was archived by the owner on Mar 20, 2024. It is now read-only.
refactor: use golang-jwt/jwt instead of dgrijalva/jwt-go #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @novalagung. I think we are missing a change in the jwt_test file? |
|
@abdulajet thanks for responding. I'll update the test, will ping you once it's ready |
…d using old go version
…d using old go version
|
@abdulajet please retest. I pushed some updates. The JWT lib is changed to github.com/golang-jwt/jwt@v3.2.1. That specific version includes an update that patches the CVE-2020-26160 |
moficodes
approved these changes
Dec 1, 2021
|
@novalagung thanks for the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refer to CVE-2020-26160
it's recommended to use
github.com/golang-jwt/jwtinstead ofgithub.com/dgrijalva/jwt-go. the lib is backward compatible. it is actually the cloned version of dgrijalva's and actively maintained.