Loosen up and fix URN parsing #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gine and adhering to 'string' spec in regard to it being any string without double colons
Not that I need them, but what is wrong with double colons in the resourceName? ;) |
|
It turns out that for URNs not to match spec is not a big deal for Pulumi
as they basically turned resource name into `(?s:.*)`, so yes, it seems
that they did not validate resource names so hard that now they have to
support newlines in them. We could mirror that (and we do, for stuff coming
from engine) but I would like to preserve a bit of sanity in resource names
mostly because I'm convinced that:
a) somebody will or already did implement a parser that partitions by ::
and additional out of spec double colons will trip it
b) newlines in resource names are not escaped in cli and will break tui
Also, ocd. There's a spec. Let's be predictable and respect the spec.
…On Mon 12. Feb 2024 at 20:10, Leonid Dubinsky ***@***.***> wrote:
@lbialy <https://github.com/lbialy>
adhering to 'string' spec in regard to it being any string without double
colons.
Not that I need them, but what is wrong with *double* colons in the
resourceName? ;)
—
Reply to this email directly, view it on GitHub
<#389 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBVNUT4NPGZXX7OFKG4XH3YTJSK5AVCNFSM6AAAAABDE5MBS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZZGM3DOMBRGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I agree: if I was writing a proper parser, that's how I would start ;)
100% |
pawelprazak
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #387 by allowing more permissive parsing of URNs coming from engine and adhering to 'string' spec in regard to it being any string without double colons.