Skip to content

Use short circuit validity checks #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 4, 2020
Merged

Use short circuit validity checks #294

merged 4 commits into from
Feb 4, 2020

Conversation

jcoupey
Copy link
Collaborator

@jcoupey jcoupey commented Jan 29, 2020 •
edited
Loading

Issue

Fixes #293

Tasks

  • Use operator&& for short-circuit evaluation
  • Update CHANGELOG.md
  • review

@jcoupey jcoupey added this to the v1.6.0 milestone Jan 29, 2020
@jcoupey jcoupey mentioned this pull request Jan 29, 2020
Closed
@jcoupey jcoupey force-pushed the enhancement/short-circuit-validity-checks branch from d1a6cfb to 3d5f1f5 Compare February 3, 2020 17:05
@jcoupey jcoupey merged commit cd73b92 into master Feb 4, 2020
@jcoupey jcoupey deleted the enhancement/short-circuit-validity-checks branch February 4, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement internals
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Short-circuit evaluation in validity checks
1 participant
@jcoupey