Skip to content

Update distances handling #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Sep 28, 2023
Merged

Update distances handling #1001

merged 20 commits into from
Sep 28, 2023

Conversation

jcoupey
Copy link
Collaborator

@jcoupey jcoupey commented Sep 26, 2023 •
edited
Loading

Issue

Fixes #957, fixes #995.

Tasks

  • Refine pattern to decide whether to report distances in output
  • Deprecate current distance-filling code in add_route_info routing wrappers
  • Update steps distance in format_solution (for RawRoute)
  • Update steps distance in format_route (for TWRoute)
  • Update steps distance in plan mode
  • Add violation check for max_distance in plan mode
  • Update CHANGELOG.md
  • review

@jcoupey jcoupey added this to the v1.14.0 milestone Sep 26, 2023
@jcoupey jcoupey merged commit deb6bc0 into master Sep 28, 2023
@jcoupey jcoupey deleted the refactor/distances branch September 28, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internals refactor
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging this pull request may close these issues.

Handle MAX_DISTANCE violations in plan mode Simplify routing wrapper add_route_info
1 participant
@jcoupey