Skip to content

Mark JobAmount and JobTime operator< as const #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2022
Merged

Mark JobAmount and JobTime operator< as const #724

merged 2 commits into from
Jun 13, 2022

Conversation

alebcay
Copy link
Contributor

@alebcay alebcay commented Jun 11, 2022 •
edited by jcoupey
Loading

Issue

Fixes #723.

Tasks

  • review

@krypt-n
Copy link
Contributor

krypt-n commented Jun 13, 2022

👍 I had to make the same change to compile on macOS

@jcoupey jcoupey added this to the v1.13.0 milestone Jun 13, 2022
jcoupey
jcoupey approved these changes Jun 13, 2022
View reviewed changes
Copy link
Collaborator

@jcoupey jcoupey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Our current CI builds did not catch this but it makes sense for a proper use of sort that the comparison operator does not alter objects!

Can you please add a changelog entry under Unreleased>Fixed?

@jcoupey jcoupey merged commit 29a478d into VROOM-Project:master Jun 13, 2022
@alebcay
Copy link
Contributor Author

alebcay commented Jun 13, 2022

Thanks for your review on quick action on this!

@alebcay alebcay deleted the const-operator-macos branch June 13, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcoupey jcoupey jcoupey approved these changes

Assignees
No one assigned
Labels
bug compilation
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

Building v1.12.0 fails on macOS
3 participants
@alebcay @krypt-n @jcoupey