Add support for disabling use of routing entirely at the compiler level #676
Conversation
- Allows the compile to take place without ASIO - Optimization still works if using a custom cost matrix - Default compilation behaviour should be identical to previous - To compile, just run `USE_ROUTING=false make`
|
Thanks for submitting this idea and a PR. It makes perfect sense to have an easy way to drop unused stuff when only using custom matrices. |
There was a problem hiding this comment.
I think this is fine as soon as we have a proper handling of input with missing custom matrices.
Please also add a changelog entry and run clang-format.
- Still include headers for routing, but don't compile .cpp files - Throw an exception when trying to call the router if we weren't compiled with routing support
|
@jcoupey Thanks for the feedback. I believe I have incorporated all of the requested changes. Please let me know if you feel I've missed anything. |
|
Thanks for the changes, the diff is actually much simpler now. I'll simply remove modification for older changelog entries (probably automatic IDE formatting) before merging. |
|
Hi @jcoupey, any idea about when the next release will be that will capture this change? I see it's been a few months since the last release and wonder if there will be one soon. Thanks! |
|
Except for the entry on PDPTW, unreleased stuff is pretty much technical but not directly related to solving. The next release will probably wait for more solving-related stuff to be included in |
USE_ROUTING=false makeIssue
Fixes #675