Skip to content

Unit for Timeout is not obvious #728

@kkarbowiak

Description

@kkarbowiak

Currently, Timeout is defined as std::optional<unsigned> which is confusing, as it does not convey what the timeout unit is. Only by digging deeper into the code one finds a comment that internally milliseconds are used.

We can make it more self-explanatory and type-safe by changing the type to std::optional<std::chrono::milliseconds>.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions