実行時にモデルを読む #365
Merged
実行時にモデルを読む #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
現在次の方針で考えています。
|
|
とりあえず動くようになりました。 |
qryxip
commented
Jan 4, 2023
qryxip
commented
Jan 4, 2023
|
まだ全部見れてないのですが設計方針もきれいで良さそうに感じました！！ |
qryxip
commented
Jan 4, 2023
Comment on lines
+22
to
+28
| pub(crate) static MODEL_FILE_SET: Lazy<ModelFileSet> = Lazy::new(|| { | ||
| let result = ModelFileSet::new(); | ||
| if let Err(err) = &result { | ||
| error!("ファイルを読み込めなかったためクラッシュします: {err}"); | ||
| } | ||
| result.unwrap() | ||
| }); |
There was a problem hiding this comment.
この「クラッシュ」ですが、run.exeごと巻き込みます (これはLinuxですが、多分Windowsでも同様?)。
❯ ./run
Warning: cpu_num_threads is set to 0. ( The library leaves the decision to the synthesis runtime )
2023-01-04T13:24:11.008713Z ERROR voicevox_core::status: ファイルを読み込めなかったためクラッシュします: failed to open file `/home/ryo/src/github.com/VOICEVOX/voicevox_engine/dist/run/model/metas.json`
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: failed to open file `/home/ryo/src/github.com/VOICEVOX/voicevox_engine/dist/run/model/metas.json`
Caused by:
No such file or directory (os error 2)', crates/voicevox_core/src/status.rs:27:12
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
zsh: IOT instruction (core dumped) ./run
Hiroshiba
reviewed
Jan 4, 2023
Hiroshiba
reviewed
Jan 4, 2023
Hiroshiba
reviewed
Jan 4, 2023
Hiroshiba
reviewed
Jan 4, 2023
| use fs_extra::dir::CopyOptions; | ||
|
|
||
| fn main() -> anyhow::Result<()> { | ||
| fs_extra::dir::copy( |
There was a problem hiding this comment.
更新されてない場合は上書きしないオプションとかあれば便利そうなのですが、なさそうですね･･･！
Hiroshiba
approved these changes
Jan 4, 2023
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
qryxip
commented
Jan 5, 2023
Comment on lines
+27
to
+32
| #[error("{} ({}): {source}", base_error_message(VOICEVOX_RESULT_LOAD_MODEL_ERROR), path.display())] | ||
| LoadModel { | ||
| path: PathBuf, | ||
| #[source] | ||
| source: anyhow::Error, | ||
| }, |
There was a problem hiding this comment.
ファイル自体が読めなかった場合:
2023-01-05T01:56:27.988287Z ERROR voicevox_core::status: ファイルを読み込めなかったためクラッシュします: failed to open file `/home/ryo/src/github.com/VOICEVOX/voicevox_core/example/cpp/unix/./voicevox_core/model/predict_duration-0.onnx`
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: failed to open file `/home/ryo/src/github.com/VOICEVOX/voicevox_core/example/cpp/unix/./voicevox_core/model/predict_duration-0.onnx`
Caused by:
No such file or directory (os error 2)', crates/voicevox_core/src/status.rs:30:12
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
./run.bash: line 6: 63023 Aborted (core dumped) ./build/simple_tts "$1"ファイルは読めたけどdecryptに失敗した場合:
Error(Display): modelデータ読み込みに失敗しました (/home/ryo/src/github.com/VOICEVOX/voicevox_core/example/cpp/unix/./voicevox_core/model/predict_duration-0.onnx): 不正なモデルファイルですdecryptはできたけどonnxモデルとして正しくなかった場合:
Error(Display): modelデータ読み込みに失敗しました (/home/ryo/src/github.com/VOICEVOX/voicevox_core/example/cpp/unix/./voicevox_core/model/predict_duration-0.onnx): Failed to create session: Error calling ONNX Runtime C function: No graph was found in the protobuf.
qwerty2501
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
今
include_bytes!しているonnxファイルを実行時に読むようにします。関連 Issue
Fixes #362.
その他