[Rust] voicevox_load_openjtalk_dict を実装した #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PickledChair
commented
Jul 16, 2022
| pub fn load(&mut self, mecab_dict_dir: impl AsRef<Path>) -> Result<()> { | ||
| let result = self.mecab.load(mecab_dict_dir.as_ref()); | ||
| if result { | ||
| self.dict_loaded = true; | ||
| Ok(()) | ||
| } else { | ||
| self.dict_loaded = false; |
There was a problem hiding this comment.
#177 (comment) の議論を踏まえて、辞書の load に失敗した時は self.dict_loaded を false に設定するように変更しました。
qwerty2501
approved these changes
Jul 16, 2022
43 tasks
qwerty2501
pushed a commit
to qwerty2501/voicevox_core
that referenced
this pull request
Jul 23, 2022
voicevox_load_openjtalk_dict を実装
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
voicevox_load_openjtalk_dictを実装しました。 #177 で一度実装していましたが、 #178 におけるInternalの設計の変更を優先するため close していました。それを再実装したものです。SynthesisEngineとInternalそれぞれで最低限のテストも実装しました。関連 Issue
ref #128