[Rust] SynthesisEngine::replace_mora_data を実装 #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
qwerty2501
reviewed
Jul 15, 2022
Hiroshiba
approved these changes
Jul 15, 2022
| PHONEME_MAP.len() | ||
| } | ||
|
|
||
| pub fn space_phoneme() -> String { |
There was a problem hiding this comment.
将来的に音素はEnumにすると型の恩恵受けられそうだなと思いました！
qwerty2501
pushed a commit
to qwerty2501/voicevox_core
that referenced
this pull request
Jul 23, 2022
* implements SynthesisEngine::replace_mora_data * implements acoustic_feature_extractor * Internal, SynthesisEngine, InferenceCore からなる構造に変更 * implements replace_phoneme_length and replace_mora_pitch * resolve clippy warnings * allow dead_code * trivial change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
SynthesisEngine::replace_mora_dataを実装します。また、このメソッドの実装にはSynthesisEngine::replace_phoneme_lengthおよびSynthesisEngine::replace_mora_pitchも必要なので、これらのメソッドも実装します。SynthesisEngine::replace_mora_dataSynthesisEngine::replace_phoneme_lengthSynthesisEngine::replace_mora_pitch関連 Issue
ref #128