Skip to content

Conversation

qwerty2501
Copy link
Contributor

内容

voicevox_coreで使うOpenJtalk部分を実装した

関連 Issue

refs #128

その他

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@qwerty2501 qwerty2501 marked this pull request as draft July 4, 2022 10:12
@qwerty2501
Copy link
Contributor Author

ちょっとなおしたいのでいったんdraftにしました

@qwerty2501 qwerty2501 marked this pull request as ready for review July 4, 2022 12:11
@qwerty2501
Copy link
Contributor Author

なおしたのでdraft外しました

@Hiroshiba
Copy link
Member

あ、 @PickledChair さんもぜひレビュー頂けると・・・!

Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューが遅くなりすみませんでした……! open_jtalk-rs の方も見ましたが、薄い wrapper でありつつも使い勝手の良さや綺麗な抽象化が目指されていて非常に勉強になりました。

ほぼ問題なさそうでしたが、一箇所だけ処理が足りなさそうな部分を見つけたので、ご確認よろしくお願いします……!

mecab2njdが抜けていたので追加

Co-authored-by: Gray Suitcase <41382894+PickledChair@users.noreply.github.com>
@qwerty2501
Copy link
Contributor Author

@PickledChair そのまま反映しました

Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! マージします……!

@PickledChair PickledChair merged commit 2f57a17 into VOICEVOX:rust Jul 10, 2022
qwerty2501 added a commit to qwerty2501/voicevox_core that referenced this pull request Jul 23, 2022
* OpenJtalkを実装した

refs VOICEVOX#128

* open_jtalk-rs更新

* Update crates/voicevox_core/src/engine/open_jtalk.rs

mecab2njdが抜けていたので追加

Co-authored-by: Gray Suitcase <41382894+PickledChair@users.noreply.github.com>

Co-authored-by: Gray Suitcase <41382894+PickledChair@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants