fix(downloader): --devicesのhelpの"(cudaはlinuxのみ)"を削除
#1124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an outdated help message for the --devices command-line option in the downloader. The change removes the incorrect "(cudaはlinuxのみ)" (CUDA is Linux only) text from the help description, as this restriction has not been accurate since the early versions of the tool.
- Removes outdated platform restriction information from the
--deviceshelp text - Updates the changelog to document this fix with proper historical context
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/downloader/src/main.rs | Removes the "(cudaはlinuxのみ)" text from the --devices argument help description |
| CHANGELOG.md | Adds changelog entry documenting the fix and references the historical PR |
|
当時の実装を見てみたのですが、"(cudaはlinuxのみ)"というのは当時は正しかった！ 正しくなくなったのは #810 が入った0.16.0-preview.0からでした…。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
--devices <DEVICES>...のhelpにはRust版ダウンローダー誕生 (#375)の時点から、PowerShell版から引き継ぐ形で「(cudaはlinuxのみ)」と書かれていた。しかしこれはRust版、というよりPowerShell版の誕生 (#249)の時点で正しくなかった。正しくなくなったのは #810 からでした！
関連 Issue
その他