fix!: [Java] fix up #802: SupportedDevicesを移動
#991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef311d1 to
d4184f2
Compare
|
これは心を鬼にして後回しで…！！！ |
SupportedDevicesを移動SupportedDevicesを移動
|
commit prefixを考えなおして、 |
There was a problem hiding this comment.
PR Overview
This PR moves the SupportedDevices class out of GlobalInfo, addressing TODOs and preparing for a Jackson migration in the future.
- Created a dedicated SupportedDevices.java to hold device information for ONNX Runtime.
- Updated usage references in onnxruntime.rs, InfoTest.java, and Onnxruntime.java to reflect the relocation.
- Removed the nested SupportedDevices class from GlobalInfo to clean up redundant code.
Reviewed Changes
| File | Description |
|---|---|
| crates/voicevox_core_java_api/lib/src/main/java/jp/hiroshiba/voicevoxcore/SupportedDevices.java | New file containing the SupportedDevices class with updated Javadoc. |
| crates/voicevox_core_java_api/src/onnxruntime.rs | Updated JNI object instantiation to refer to the new SupportedDevices class. |
| crates/voicevox_core_java_api/lib/src/test/java/jp/hiroshiba/voicevoxcore/InfoTest.java | Updated test references from GlobalInfo.SupportedDevices to SupportedDevices. |
| crates/voicevox_core_java_api/lib/src/main/java/jp/hiroshiba/voicevoxcore/blocking/Onnxruntime.java | Updated import statement to reference the new SupportedDevices class. |
| crates/voicevox_core_java_api/lib/src/main/java/jp/hiroshiba/voicevoxcore/GlobalInfo.java | Removed the deprecated nested SupportedDevices class and its related code. |
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Hiroshiba
approved these changes
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
TODOを解消する形。
BREAKING-CHANGE:
GlobalInfo$SupportedDevices→SupportedDevices。関連 Issue
その他