macos-latest = macos-14に適応する
#784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
commented
Apr 29, 2024
Comment on lines
-280
to
-286
| # `macos-latest`(=`macos-12`)で次の問題が発生するため、それに対するワークアラウンド | ||
| # https://github.com/VOICEVOX/voicevox_core/issues/653#issuecomment-1782108410 | ||
| - if: startsWith(matrix.os, 'mac') | ||
| name: Build open_jtalk-sys | ||
| run: | | ||
| poetry run -- cargo build -p voicevox_core_python_api -vv || true | ||
| [ -n "$(find ../../target/debug/deps -name 'libopen_jtalk_sys-*.rlib')" ] |
There was a problem hiding this comment.
今これを抜いて実行してみても通ったので、多分もう不要。
.github/workflows/test.yml
Outdated
Comment on lines
315
to
308
| uses: actions/setup-java@v2 | ||
| uses: actions/setup-java@v3 |
There was a problem hiding this comment.
よくわからないが、v2だとx86_64のJavaを持ってきてしまう。
(ちなみに現在の最新はv4)
There was a problem hiding this comment.
特に問題が無ければv4に上げても良さそうな気がします。
There was a problem hiding this comment.
まあ確かにここはv4でもいいかなとは思いました。
(他のは別PRで一斉に引き上げるとして)
|
@Hiroshiba 文脈を補足すると、mainブランチのCIが壊れており(rerunすると落ちる)それに対する修正です。 |
sevenc-nanashi
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
macos-latestがmacos-14(AArch64)になったためそれに対応します。https://github.com/qryxip/voicevox_core/actions/runs/8869988493/job/24351267440
関連 Issue
その他