Fix: UserDict.to_mecab_formatが2重に改行していたのを修正 #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sevenc-nanashi #1109 をやっているときにこのPRが気になり、現行のmainブランチをベースに二重改行の状態にして試してみたのですが、警告が表示されるものの個々の単語登録はちゃんと機能しました。「Fix: ユーザー辞書に2個以上単語が入ってると死ぬバグを修正」とありますが、当時もこのような感じだったでしょうか？ /home/ryo/src/github.com/VOICEVOX/voicevox_core/main/target/release/build/open_jtalk-sys-3e844eb0ffe6e546/out/build/_deps/openjtalk-src/src/mecab/src/dictionary.cpp(346) [n == 5] format error:
empty word is found, discard this line
aq.kana="テ'フダ、ボ'イスボッ_クス"コードfrom voicevox_core.blocking import OpenJtalk, UserDict
from voicevox_core import AudioQuery, UserDictWord
ojt = OpenJtalk("./voicevox_core/dict/open_jtalk_dic_utf_8-1.11")
userdict = UserDict()
userdict.add_word(UserDictWord("手札", "テフダ", 1, priority=6)) # システム辞書には'シュサツ'として登録
userdict.add_word(UserDictWord("VOICEVOX", "ボイスボックス", 1)) # kanalizerはまだ未実装
ojt.use_user_dict(userdict)
aq = AudioQuery.from_accent_phrases(ojt.analyze("手札、VOICEVOX"))
print(f"{aq.kana=}") |
|
うーん、当時のことを覚えてないのでわからないですね… #733 と勘違いしてたのかも。 |
|
あーなるほど。ありがとうございました。 まあ今更深く掘り返す価値はなさそうですし、「Open JTalkが変な警告を出していたのが無くなります」としておきます。 |
|
ちょっと良い機会なのでコメントまで。 （今回のようなヒヤリハットの時点で意識しておかないと大事故につながる） |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
タイトル通りです。
関連 Issue
（なし）
その他
（なし）