Skip to content

"new_with_initialize" → "new" #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2023
Merged

"new_with_initialize" → "new" #669

merged 1 commit into from
Oct 31, 2023

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Oct 31, 2023 •
edited
Loading

内容

Synthesizer::new_with_initializeとOpenJtalk::new_with_initialize、およびそれに対応するFFIをすべてリネームします。

Synthesizerの方にはそもそも今は「initialize抜きのnew」が存在せず、OpenJtalkの方はOption<OpenJtalk>として運用すればよいです。
（このあたりの話はどこかでした気がするけど、見あたらない…）

関連 Issue

#545

その他

@qryxip qryxip requested review from Hiroshiba, qwerty2501 and sevenc-nanashi and removed request for qwerty2501 October 31, 2023 15:31
@qryxip
Copy link
Member Author

qryxip commented Oct 31, 2023

@qwerty2501 すみません、今間違えてreview request飛ばしました…

Hiroshiba
Hiroshiba approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！！

ちょっとnewの処理が重めで、一般的なコンストラクターとしては予想外の挙動をしているかもとは思いました。
けどまぁ @qryxip さん的にそこまで違和感ないくらいの感じでしたら、そんな問題じゃないかなと！
（must/should/want/canで言うところの、wantからcanの間くらいの意見です）

sevenc-nanashi
sevenc-nanashi approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@sevenc-nanashi sevenc-nanashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

テストも通ってるし大丈夫だと思います。

@Hiroshiba Hiroshiba merged commit a6fb4ae into VOICEVOX:main Oct 31, 2023
@qryxip qryxip mentioned this pull request Oct 31, 2023
Open
69 tasks
@qryxip qryxip mentioned this pull request Nov 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

@sevenc-nanashi sevenc-nanashi sevenc-nanashi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qryxip @Hiroshiba @sevenc-nanashi