[project-vvm-async-api] $OUT_DIRを使うものをtest_utilクレートに移動
#515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
commented
Jun 10, 2023
|
|
||
| use crate::VoiceModel; | ||
|
|
||
| pub async fn open_default_vvm_file() -> VoiceModel { | ||
| VoiceModel::from_path( | ||
| convert_zip_vvm( | ||
| ::test_util::convert_zip_vvm( |
There was a problem hiding this comment.
open_default_vvm_fileはこっちに残す。
Rustではdev-dependencyの関係に限り「クレートの相互依存」ができるものの、「voicevox_coreクレート」と「test_util側から見えるvoicevox_coreクレート」が別物として扱われてしまう(?)ため、voicevox_core::VoiceModelを生成する関数は外に出せない。
Hiroshiba
approved these changes
Jun 10, 2023
|
たぶん問題ないと思うのでマージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
project-vvm-async-apiにそろそろmainをマージしようと思ったのですが、こっちではこのままだと #508 が適用できないことに気付きました。
このPRはvoicevox_coreクレート内で
$OUT_DIRを使っているテストユーティリティを、test_utilクレートに移動します。関連 Issue
#497
その他