Skip to content

Pythonコードをリファクタ #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 20, 2023
Merged

Pythonコードをリファクタ #495

merged 4 commits into from
May 20, 2023

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented May 19, 2023 •
edited
Loading

内容

  1. example/pythonのdead codeを削ります。
  2. isort(profile=black)をかけます。

特に1.は忘れそうなので今PRを出しておきます。

関連 Issue

その他

@PickledChair
Copy link
Member

PickledChair commented May 20, 2023 •
edited
Loading

dead code に気づいていませんでした。良いと思います！
あと、昨日 example のコードと README に誤植を見つけていました。ついでに直してもらったりはできますか……？（speeker -> speaker）

voicevox_core/example/python/run.py

Line 74 in babce87

"--speeker-id",

voicevox_core/example/python/run.py

Line 80 in babce87

return (args.mode, args.dict_dir, args.text, args.out, args.speeker_id)

voicevox_core/example/python/README.md

Line 63 in babce87

--speeker-id SPEEKER_ID

@qryxip
Copy link
Member Author

qryxip commented May 20, 2023

あ、本当だ。直しました。

PickledChair
PickledChair approved these changes May 20, 2023
View reviewed changes
Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

sevenc-nanashi
sevenc-nanashi approved these changes May 20, 2023
View reviewed changes
Copy link
Member

@sevenc-nanashi sevenc-nanashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMですー。
black、isortのチェックworkflowがあっても良さそうな感じがしました。（py/pyiファイルが変更されたら発火する感じ）

@qryxip qryxip merged commit 406f6c4 into VOICEVOX:main May 20, 2023
This was referenced May 20, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PickledChair PickledChair PickledChair approved these changes

@sevenc-nanashi sevenc-nanashi sevenc-nanashi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qryxip @PickledChair @sevenc-nanashi