cbindgenが生成するvoicevox_core.hをこのリポジトリに追加する #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi
approved these changes
May 19, 2023
|
ヘッダファイルの diff が検出しやすくなるので良い変更だと思いました！ このままでも問題ないと思うのですが、ちょっと提案があります。今後 voicevox_core/.github/workflows/build_and_deploy.yml Lines 153 to 155 in 546e173 以下のコピー元を （大して意味がなさそうでしたらこのままでも良いです。あるいは、何か懸念がありそうでしたらご指摘お願いします） |
|
忘れてました。 |
こっちも単純に忘れてました。.lockファイルと同じく、クリックしたら普通にdiffは見れるので入れた方がいいと思いました。 |
This was referenced May 19, 2023
Merged
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
cbindgenが生成するvoicevox_core.hをこのリポジトリに追加します。
関連 Issue
Resolves #488.
その他