Skip to content

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented May 9, 2023

内容

#[serde(default)]を入れて、ENGINEでは省略可能なフィールドを省略できるようにします。

関連 Issue

その他

@qryxip qryxip changed the title 抜けていた#[serde(default)]を入れる #[serde(default)]を入れる May 9, 2023
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

問題ないと思うので、suggestを含めてマージします!

Co-authored-by: Ryo Yamashita <qryxip@gmail.com>
@Hiroshiba Hiroshiba merged commit 7452255 into VOICEVOX:main May 12, 2023
@qryxip qryxip deleted the add-missing-serde-default branch May 12, 2023 13:37
@qryxip qryxip mentioned this pull request May 13, 2023
qryxip added a commit to qryxip/voicevox_core that referenced this pull request May 13, 2023
Hiroshiba pushed a commit that referenced this pull request May 13, 2023
@qryxip qryxip mentioned this pull request May 22, 2023
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants