Skip to content

Add: #479 のPython APIを追加 #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 7, 2023
Merged

Add: #479 のPython APIを追加 #483

merged 4 commits into from
May 7, 2023

Conversation

sevenc-nanashi
Copy link
Member

@sevenc-nanashi sevenc-nanashi commented May 6, 2023 •
edited
Loading

内容

タイトル通り。

関連 Issue

その他

Rustは勉強中なので非効率的な書き方かも知れません。

サンプル 
import ctypes
import os
from pprint import pprint

ctypes.cdll.LoadLibrary(
    "/home/sevenc7c/onnxruntime-linux-x64-1.14.0/lib/libonnxruntime.so.1.14.0"
)
os.environ["VV_MODELS_ROOT_DIR"] = "/home/sevenc7c/voicevox/core/model"

import voicevox_core

c = voicevox_core.VoicevoxCore(
    open_jtalk_dict_dir="/home/sevenc7c/open_jtalk_dic_utf_8-1.11"
)
c.load_model(0)

base_phrases = c.accent_phrases("もち", 0)
pprint(base_phrases)

length_replaced = c.mora_length(base_phrases, 1)
pprint(length_replaced)

pitch_replaced = c.mora_pitch(base_phrases, 1)
pprint(pitch_replaced)

data_replaced = c.mora_data(base_phrases, 1)
pprint(data_replaced)
❯ python3 __gi_test.py 
[AccentPhrase(moras=[Mora(text='モ', consonant='m', consonant_length=0.04455498, vowel='o', vowel_length=0.12857193, pitch=5.729677), Mora(text='チ', consonant='ch', consonant_length=0.10641824, vowel='i', vowel_length=0.14448714, pitch=5.9074173)], accent=2, pause_mora=None, is_interrogative=False)]
[AccentPhrase(moras=[Mora(text='モ', consonant='m', consonant_length=0.042567946, vowel='o', vowel_length=0.13342857, pitch=5.729677), Mora(text='チ', consonant='ch', consonant_length=0.11405793, vowel='i', vowel_length=0.18405052, pitch=5.9074173)], accent=2, pause_mora=None, is_interrogative=False)]
[AccentPhrase(moras=[Mora(text='モ', consonant='m', consonant_length=0.04455498, vowel='o', vowel_length=0.12857193, pitch=5.7345743), Mora(text='チ', consonant='ch', consonant_length=0.10641824, vowel='i', vowel_length=0.14448714, pitch=5.9614882)], accent=2, pause_mora=None, is_interrogative=False)]
[AccentPhrase(moras=[Mora(text='モ', consonant='m', consonant_length=0.042567946, vowel='o', vowel_length=0.13342857, pitch=5.7345743), Mora(text='チ', consonant='ch', consonant_length=0.11405793, vowel='i', vowel_length=0.18405052, pitch=5.9614882)], accent=2, pause_mora=None, is_interrogative=False)]

qryxip
qryxip approved these changes May 6, 2023
View reviewed changes
Copy link
Member

@qryxip qryxip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

十分に良いRustのコードだと思います。
動くみたいだしLGTM

@qryxip
Copy link
Member

qryxip commented May 6, 2023

ところで#482ってlinkしていいんでしたっけ? そっちはpytestとかでテストを書くという話だったんじゃないかと...

@sevenc-nanashi
Copy link
Member Author

あ、 #480 ですね

@qryxip
Copy link
Member

qryxip commented May 6, 2023

:naruhodo:

PickledChair
PickledChair approved these changes May 7, 2023
View reviewed changes
Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@PickledChair PickledChair merged commit ff7b5a8 into VOICEVOX:main May 7, 2023
sevenc-nanashi added a commit to sevenc-nanashi/voicevox_core that referenced this pull request May 7, 2023
@sevenc-nanashi
Add: VOICEVOX#483 のテストを追加
628cf37
@qryxip qryxip mentioned this pull request May 13, 2023
Closed
@qryxip qryxip mentioned this pull request May 22, 2023
Merged
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qryxip qryxip qryxip approved these changes

@PickledChair PickledChair PickledChair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

accent_phrasesなどのC APIのPython実装を足す
3 participants
@sevenc-nanashi @qryxip @PickledChair