Skip to content

Add: C APIに中レベル（？）のAPIを追加 #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 1, 2023
Merged

Add: C APIに中レベル（？）のAPIを追加 #479

merged 15 commits into from
May 1, 2023

Conversation

sevenc-nanashi
Copy link
Member

内容

以下のAPIを追加します：

  • voicevox_accent_phrases
  • voicevox_mora_pitch
  • voicevox_mora_length
  • voicevox_mora_data

関連 Issue

（なし）

その他

（なし）

sevenc-nanashi
sevenc-nanashi commented Apr 30, 2023
View reviewed changes
@sevenc-nanashi sevenc-nanashi requested a review from qryxip April 30, 2023 12:59
qryxip
qryxip reviewed Apr 30, 2023
View reviewed changes
Copy link
Member

@qryxip qryxip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#370 にそもそもないのも結構ありますね。必要性がだいぶ理解できてきました。

#370 と盛大にコンフリクトして多分原型はあまり残らなくなるとは思いますが、今mainに取り込む意義は十分にあるかと思います。VOICEVOX_RESULT_INVALID_ACCENT_PHRASE_ERRORとかむしろ #370 側にあるべきものかと思いますし (今見たらパニック(i.e. クラッシュしてプロセスごと強制終了)になってました)、

@sevenc-nanashi
Copy link
Member Author

CI通りました。

PickledChair
PickledChair reviewed May 1, 2023
View reviewed changes
@qryxip qryxip mentioned this pull request May 1, 2023
Merged
PickledChair
PickledChair approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@sevenc-nanashi sevenc-nanashi mentioned this pull request May 1, 2023
Merged
@sevenc-nanashi sevenc-nanashi requested a review from qryxip May 1, 2023 12:41
qryxip
qryxip approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@qryxip qryxip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qryxip
Copy link
Member

qryxip commented May 1, 2023

Python APIが更新されてませんが、まあ #370 までのつなぎとしては良いと思うのでマージします。

@qryxip qryxip merged commit 629fa0b into VOICEVOX:main May 1, 2023
@Hiroshiba Hiroshiba mentioned this pull request May 1, 2023
Closed
@Hiroshiba
Copy link
Member

Python側の実装忘れそうなのでissueにしておきました！

@sevenc-nanashi sevenc-nanashi mentioned this pull request May 6, 2023
Open
PickledChair pushed a commit that referenced this pull request May 7, 2023
@sevenc-nanashi
Add: #479 のPython APIを追加 (#483)
ff7b5a8 
* Add: pyiに定義を追加

* Add: accent_phrasesを実装

* Add: mora_系を実装

* Refactor: mora_系を共通化
@sh1ma sh1ma mentioned this pull request May 19, 2023
Closed
24 tasks
@sevenc-nanashi sevenc-nanashi mentioned this pull request Jun 8, 2023
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qryxip qryxip qryxip approved these changes

@PickledChair PickledChair PickledChair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sevenc-nanashi @qryxip @Hiroshiba @PickledChair