Skip to content

Conversation

Hiroshiba
Copy link
Member

@Hiroshiba Hiroshiba commented Mar 19, 2022

内容

storeのUILockを使っていることで生じているバグを取り除きます。
とりあえずcreateUILockActionをコンポーネント内に定義してごまかすようにしてみました。

関連 Issue

ref #724

close #727

@Hiroshiba Hiroshiba force-pushed the 辞書ダイアログ内のUILockを分ける branch from 27c8049 to 7cb4581 Compare March 20, 2022 13:51
@Hiroshiba Hiroshiba marked this pull request as ready for review March 20, 2022 13:51
@Hiroshiba Hiroshiba requested a review from y-chan March 20, 2022 13:53
@Hiroshiba
Copy link
Member Author

rebaseしたのでレビューもらえると・・・! @y-chan

Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです、対応ありがとうございます...!

@Hiroshiba Hiroshiba merged commit f83ca5f into VOICEVOX:main Mar 24, 2022
@Hiroshiba Hiroshiba deleted the 辞書ダイアログ内のUILockを分ける branch March 24, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

辞書UIの初回起動で単語追加ができない
2 participants