Skip to content

Reuse Client in Registry when downloading packages #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2021
Merged

Reuse Client in Registry when downloading packages #27

merged 1 commit into from
Aug 31, 2021

Conversation

ok-nick
Copy link
Contributor

@ok-nick ok-nick commented Aug 24, 2021

Store the Client in the struct rather than creating a new one per package download.
This is suggested by the reqwest docs for when multiple http requests are being made.

LPGhatguy
LPGhatguy approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@LPGhatguy LPGhatguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and easy fix, thank you!

@LPGhatguy LPGhatguy merged commit dd016d8 into UpliftGames:main Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@LPGhatguy LPGhatguy LPGhatguy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ok-nick @LPGhatguy