Skip to content

Fix improper WallyPackageMetadata type #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2023
Merged

Fix improper WallyPackageMetadata type #110

merged 1 commit into from
Mar 6, 2023

Conversation

boatbomber
Copy link
Contributor

Credit to @OverHash for catching this and showing me the correct way to do it.

OverHash
OverHash approved these changes Mar 5, 2023
View reviewed changes
Copy link

@OverHash OverHash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to add a comment indicating the source of WallyPackageMetadata (Manifest inside wally/src/manifest.rs)

@magnalite magnalite merged commit 9663c52 into UpliftGames:main Mar 6, 2023
@boatbomber boatbomber deleted the fix/wally-types branch March 10, 2023 15:56
@chenrui333 chenrui333 mentioned this pull request Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@magnalite magnalite magnalite approved these changes

@OverHash OverHash OverHash approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boatbomber @magnalite @OverHash