[MLA-2017] Move colab notebooks to github #5399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
commented
May 27, 2021
| @@ -125,6 +125,7 @@ repos: | |||
| name: validate release links | |||
| language: script | |||
| entry: utils/validate_release_links.py | |||
| require_serial: true | |||
There was a problem hiding this comment.
This was causing problems trying to run with --all-files, since multiple processes would all try to modify the same file, and the replacements weren't atomic.
chriselion
commented
May 27, 2021
| " import mlagents\n", | ||
| " print(\"ml-agents already installed\")\n", | ||
| "except ImportError:\n", | ||
| " !pip install -q mlagents==0.25.1\n", |
There was a problem hiding this comment.
This will get updated by the link+pip updater on the next release branch.
vincentpierre
approved these changes
Jun 1, 2021
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Move the colab notebooks (back?) to source control. This is the first step in running CI on them.
A fast-follow PR will update the links on https://github.com/Unity-Technologies/ml-agents/tree/main/docs to point to the
mainversions (with the https://colab.research.google.com prefix).After we branch for the next release, I'll change the links to use
release_N_docsso that they continue to match the branch they're on (or the previous release).Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
https://colab.research.google.com/github/Unity-Technologies/ml-agents/blob/MLA-2017-colab-to-github/colab/Colab_UnityEnvironment_1_Run.ipynb
https://colab.research.google.com/github/Unity-Technologies/ml-agents/blob/MLA-2017-colab-to-github/colab/Colab_UnityEnvironment_2_Train.ipynb
https://colab.research.google.com/github/Unity-Technologies/ml-agents/blob/MLA-2017-colab-to-github/colab/Colab_UnityEnvironment_3_SideChannel.ipynb
Types of change(s)
Checklist
Other comments