Adding a SensorName field to BufferSensor #5020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
reviewed
Mar 1, 2021
| /// Name of the generated <see cref="bufferSensor"/> object. | ||
| /// Note that changing this at runtime does not affect how the Agent sorts the sensors. | ||
| /// </summary> | ||
| public string SensorName |
There was a problem hiding this comment.
Actually, I think all of these (name, ObservableSize, MaxNumObservables) need
- private storage
- public get/set accessors.
- a custom editor (don't let any of the fields get updated during play mode)
There was a problem hiding this comment.
Ok, I just found the CameraSensorComponentEditor and I will use that as a base.
There was a problem hiding this comment.
Sounds good. I think this might even be simpler than CameraSensorComponentEditor, since I don't think there's anything that reasonably editable at runtime.
chriselion
reviewed
Mar 2, 2021
| @@ -98,7 +100,7 @@ public SensorCompressionType GetCompressionType() | |||
|
|
|||
| public string GetName() | |||
| { | |||
| return "BufferSensor"; | |||
| return m_Name; | |||
There was a problem hiding this comment.
nit: add /// <inheritdoc/> to this and GetCompressionType()
chriselion
approved these changes
Mar 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Adding a SensorName field to BufferSensor in order to have more than one BufferSensor per Agent.
Modified the changelog to include the new BufferSensor (Was missing before)
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments