Skip to content

Conversation

vincentpierre
Copy link
Contributor

Proposed change(s)

This PR adds a section to the ML-Agents overview describing variable length observation and removes some old bullets from the list of feature in the main ML-Agents readme.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

This slack message
This JIRA ticket

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

@vincentpierre vincentpierre self-assigned this Feb 18, 2021
@@ -26,17 +26,14 @@ developer communities.

## Features

- 15+ [example Unity environments](docs/Learning-Environment-Examples.md)
- Support for multiple environment configurations and training scenarios
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why delete lines 30, 31 and 39?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I did not like them anymore :)
I can put them back

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha - let's put them back.

@@ -684,6 +684,23 @@ three network architectures:
The choice of the architecture depends on the visual complexity of the scene and
the available computational resources.

### Learning from Variable Length Observations using Attention

Using the ML-Agents Toolkit, it is possible to have agents learn from a
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this section should start with an example of where you may have different inputs to help a non-RL expert understand when and why they want to use it. (See subsection below for instance.)

about variable length observations and the BufferSensor
[here](Learning-Environment-Design-Agents.md#variable-length-observations).
When variable length observations are utilized, the ML-Agents Toolkit
leverages attention networks to learn from a varying number of entities.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a reference to attention networks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a reference already in the section Learning-Environment-Design-Agents.md#variable-length-observations I think we should minimize the number of places with external references and avoid duplicate references.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oks oks.

@@ -684,6 +684,23 @@ three network architectures:
The choice of the architecture depends on the visual complexity of the scene and
the available computational resources.

### Learning from Variable Length Observations using Attention
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • need to update the Toc above with a link to this section.
  • any visuals we can add?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try to make another comic book

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for comic book.

Copy link

@mmattar mmattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asked to add back Features... but ow love it.

@@ -684,6 +684,23 @@ three network architectures:
The choice of the architecture depends on the visual complexity of the scene and
the available computational resources.

### Learning from Variable Length Observations using Attention
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for comic book.

about variable length observations and the BufferSensor
[here](Learning-Environment-Design-Agents.md#variable-length-observations).
When variable length observations are utilized, the ML-Agents Toolkit
leverages attention networks to learn from a varying number of entities.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oks oks.

@vincentpierre vincentpierre merged commit 444ca05 into master Feb 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the docs-add-var-len-obs-to-readme-and-overview branch February 23, 2021 21:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants