Skip to content

pass sensor dimension flags to analytics #4954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2021
Merged

pass sensor dimension flags to analytics #4954

merged 1 commit into from
Feb 19, 2021

Conversation

chriselion
Copy link
Contributor

@chriselion chriselion commented Feb 17, 2021 •
edited
Loading

Proposed change(s)

We started using Dimension Properties in #4909; this updates analytics to read them from the sensor (if applicable).

Types of change(s)

  • New feature

Checklist

  • Added tests that prove my fix is effective or that my feature works

Other comments

@chriselion chriselion merged commit 79f2303 into master Feb 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the analytics-set-sensor-dim-flags branch February 19, 2021 04:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@vincentpierre vincentpierre vincentpierre approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriselion @vincentpierre