-
Notifications
You must be signed in to change notification settings - Fork 4.3k
[WIP] Critic LSTM memories #4948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewcoh
reviewed
Feb 16, 2021
andrewcoh
reviewed
Feb 16, 2021
andrewcoh
reviewed
Feb 19, 2021
andrewcoh
reviewed
Feb 19, 2021
andrewcoh
approved these changes
Feb 19, 2021
08d2c7d
to
b39c1f6
Compare
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
The Actor/Critic split will not allow us to evaluate the critic memories during inference (i.e, in
policy.get_action()
. This PR introduces a workaround, where the values are computed duringget_trajectory_value_estimates()
in the optimizer. We have to compute the value and resulting memories per sequence in each trajectory that is passed to this function.Furthermore, initial memories per sequence were the current memories, not the previous (has been the case since forever). For instance, if you take a step at time t with obs_t, and get action_t and memory_t, when initializing the LSTM you want to use memory_(t-1). This PR fixes that for the policy memories.
Types of change(s)
Checklist
Other comments