Skip to content

[WIP] Critic LSTM memories #4948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Feb 24, 2021
Merged

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented Feb 16, 2021

Proposed change(s)

The Actor/Critic split will not allow us to evaluate the critic memories during inference (i.e, in policy.get_action(). This PR introduces a workaround, where the values are computed during get_trajectory_value_estimates() in the optimizer. We have to compute the value and resulting memories per sequence in each trajectory that is passed to this function.

Furthermore, initial memories per sequence were the current memories, not the previous (has been the case since forever). For instance, if you take a step at time t with obs_t, and get action_t and memory_t, when initializing the LSTM you want to use memory_(t-1). This PR fixes that for the policy memories.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@ervteng ervteng force-pushed the develop-critic-op-lstm branch from 08d2c7d to b39c1f6 Compare February 19, 2021 21:25
@ervteng ervteng marked this pull request as ready for review February 19, 2021 21:31
@ervteng ervteng merged commit 4eb6cb3 into develop-critic-optimizer Feb 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the develop-critic-op-lstm branch February 24, 2021 19:39
@andrewcoh andrewcoh mentioned this pull request Feb 24, 2021
10 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants