-
Notifications
You must be signed in to change notification settings - Fork 213
feat: replace keybinder with DE-wrappers #1256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…old settings (or defaults)
c7449e6
to
702091c
Compare
I'm going to merge this immediately. I just added you as reviewers @troycurtisjr @gornostal to let you know. This wasn't possible to do before because of the (now fixed) focus issue. |
Posted from KDE live CD (testing): Update:The current KDE implementation (now deactivated) didn't work for me, but this did work 100% on both X11 and Wayland without focus issues on Kubuntu with systemd:
This also adds it with the rest of your application shortcuts and adds an icon. I think that's as good as it gets. To add it as a "default shortcut" instead of "custom" I think you need to make it a native KDE app and use this SDK (example). You can then open this view directly by running An older thread suggested a more naive way to restart the service, which could be coupled with The hotkey in in another format. It looks just like the "label" format you can get from the gtk accelerator one: Old postDid some testing on KDE, and found that this didn't actually work (based on an outdated article with fake date saying June this year). It can be disabled programmatically with Also, the empty space has an icon now, so I guess that's what it's supposed to have: Related article about KGlobalAccel says it's only X11 anyway: https://blog.martin-graesslin.com/blog/2015/06/global-shortcut-handling-in-a-plasma-wayland-session/ Need to test this again with kubuntu wayland |
Great stuff @friday! |
Have tested and fixed the KDE and XFCE implementations now, and they work great (after pushing fixes). So we have great support coverage already. I am pretty sure Budgie, Panteon and Cinnamon uses the same way as Gnome, but with different gsettings paths, so maybe I will add those or some of them. I won't add support for more than those though. Should be easy for contributors who are on smaller desktops to contribute. |
This replaces the keybinder dependency with a custom DE-wrapper to set the hotkey via DE-specific commands. Currently supports Gnome, KDE and XFC, but only the Gnome one has been tested.
The benefit is that this will work on both X11 and Wayland, but it won't work on unsupported DEs until users set it up themselves. There are system notifications to guide you though this though.
Rewrote much of the old code for setting the hotkey with a new better looking and more standardized dialog, and tried to make the notifications clearer (we need that now).
First launch with this PR it will try to migrate your setting or add the default, then show this
If your DE is supported it will migrate the setting to the DE shortcut settings, and show this
If it's the first time you open Ulauncher, it will default to Ctrl+space (like before)
If your DE is not supported, it will show this instead
And as it says, you will open the preferences by clicking it, with more details:
When the DE is supported, the settings look like this
Some of the details might need polish, but that can be changed later.(I have now pushed a few commits to improve the usability and robustness)